This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Replace exporter version constants with package version #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyanhui1228
approved these changes
Oct 26, 2018
lmolkova
approved these changes
Oct 26, 2018
lmolkova
left a comment
There was a problem hiding this comment.
LGTM.
Could you please also test the exact ocagent exporter version? It was only checked for not being empty here:
But now we can check that is actually correct.
Member
Author
|
Thanks @lmolkova, I updated the test. |
lmolkova
approved these changes
Oct 26, 2018
c24t
added a commit
to c24t/opencensus-python
that referenced
this pull request
Oct 29, 2018
to reflect changes in census-instrumentation#369.
Merged
c24t
added a commit
to c24t/opencensus-python
that referenced
this pull request
Dec 10, 2018
Pick up census-instrumentation#369 to replace hardcoded version with __version__ file and bump the version number.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296 by adding a top-level version file and removing hardcoded version numbers in the stackdriver and ocagent exporters.
I'm
execing the version file insetup.pyto avoid importing the opencensus package during setup. This isn't strictly necessary now, but I think this solution is simpler and likely to save us some headaches in the future.cc @lmolkova