fix(cypress): remove cypress from codebase#1082
Merged
billhimmelsbach merged 10 commits intomainfrom Dec 10, 2024
Merged
Conversation
meissadia
approved these changes
Dec 10, 2024
billhimmelsbach
added a commit
that referenced
this pull request
Mar 13, 2025
I'm really happy with where we are with our Playwright tests, so let's get rid of the cypress tests to prevent those failures from letting us have those sweet green check marks. ✅ Currently the cypress tests fail when running on commits on main due to [a missing record key](https://github.com/cfpb/sbl-frontend/actions/runs/12263581708/job/34215508209). We don't need these tests anymore, and I think now is the time to get rid of them. <img width="1234" alt="Screenshot 2024-12-10 at 2 24 59 PM" src="https://github.com/user-attachments/assets/db4ac511-17d4-4223-a6fb-24b12c04fac5"> Closes #992 - Removes cypress from deps, readme, package.json scripts, cache, and removes the folder of test files 1. Does the website still build and work? <img width="1109" alt="Screenshot 2024-12-10 at 2 22 04 PM" src="https://github.com/user-attachments/assets/822aeaf6-e47e-46e0-8f01-748399b2a424">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really happy with where we are with our Playwright tests, so let's get rid of the cypress tests to prevent those failures from letting us have those sweet green check marks. ✅
Currently the cypress tests fail when running on commits on main due to a missing record key. We don't need these tests anymore, and I think now is the time to get rid of them.
Closes #992
Changes
How to test this PR
Screenshots