Skip to content

Conversation

@gep13
Copy link
Member

@gep13 gep13 commented Dec 18, 2024

combintation -> combination

Description Of Changes

Fixed a typo that was noticed while reviewing other code.

Motivation and Context

Once seen, it cannot be unseen, and must be fixed.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@gep13 gep13 requested a review from pauby December 18, 2024 10:13
@gep13
Copy link
Member Author

gep13 commented Dec 18, 2024

@pauby if you are happy with this change, we should assign this PR to the next milestone for CLI, and get this merged in.

@pauby pauby added this to the vNext milestone Dec 18, 2024
@pauby
Copy link
Member

pauby commented Dec 18, 2024

@gep13 I have approved this and assigned it to vNext milestone. I'm assuming we'll merge it in at that time rather than now.

@gep13
Copy link
Member Author

gep13 commented Dec 18, 2024

@pauby said...
I'm assuming we'll merge it in at that time rather than now.

vNext will go out from what is contained within the develop branch, so there is nothing to prevent this being merged in now. We just need to remember to switch the milestone for this PR, once we know what vNext is going to be.

@pauby pauby modified the milestones: vNext, 2.5.0 May 11, 2025
combintation -> combination
@gep13
Copy link
Member Author

gep13 commented May 29, 2025

@pauby given the approval has been given, and we are ready to move forward with vNext, I am going to get this merged in.

@gep13 gep13 merged commit e3d4af7 into chocolatey:develop May 29, 2025
1 check passed
@gep13 gep13 deleted the fix-typo branch May 29, 2025 06:33
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member. Documentation Issues for changes that only need to change documentation. labels Jun 5, 2025
@gep13 gep13 changed the title (doc) Fix typo Fix typo in --online option Jul 9, 2025
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption. and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member. labels Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Released The issue has been resolved, and released to the public for consumption. Documentation Issues for changes that only need to change documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants