Added eslint plugin to disallow using "import" keyword in debug comments #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
reviewed
Nov 2, 2022
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
pomek
requested changes
Nov 2, 2022
Member
pomek
left a comment
There was a problem hiding this comment.
At first look, everything looks good. However, we need to polish the new rule and support more options that the CKEditor 5 testing environment understands.
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-ckeditor5-rules/tests/use-require-for-debug-mode-imports.js
Show resolved
Hide resolved
psmyrek
reviewed
Nov 3, 2022
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-ckeditor5-rules/lib/rules/use-require-for-debug-mode-imports.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal (eslint-plugin-ckeditor5-rules): Added eslint plugin to disallow using the "import" keyword in debug comments. Closes ckeditor/ckeditor5#12479.