Split metrics (cached) and tracing (uncached) label decoding#363
Merged
bobrik merged 1 commit intocloudflare:masterfrom Mar 25, 2024
Merged
Split metrics (cached) and tracing (uncached) label decoding#363bobrik merged 1 commit intocloudflare:masterfrom
bobrik merged 1 commit intocloudflare:masterfrom
Conversation
In tracing there is no concern with cardinality and one can have PID as a label. With caching enabled, this means that we grow the cache map indefinitely, leaking memory until OOM stops us. Let's disable caching for tracing instead.
Contributor
Author
|
Perhaps an LRU with 1k entries per config is a better option here. |
Contributor
Author
|
With LRU there's overhead in terms of CPU for the metrics case: There is no overhead for metrics with separate methods. For tracing we have a set of nearly unique labels that are not worth caching: - name: trace_id
size: 16
decoders:
- name: hex
- name: parent_span_id
size: 8
decoders:
- name: hex
- name: span_id
size: 8
decoders:
- name: hex
- name: span_monotonic_timestamp_ns
size: 8
decoders:
- name: uint
- name: span_duration_ns
size: 8
decoders:
- name: uintGiven that we cache the whole input with unique and non-unique fields, there's zero chance of actually caching anything for tracing. There doesn't seem to be any point in LRU then. |
dqminh
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tracing there is no concern with cardinality and one can have PID as a label. With caching enabled, this means that we grow the cache map indefinitely, leaking memory until OOM stops us. Let's disable caching for tracing instead.