Add cgroup observer to prevent infinite fanotify growth#443
Merged
bobrik merged 1 commit intocloudflare:masterfrom Jun 28, 2024
Merged
Add cgroup observer to prevent infinite fanotify growth#443bobrik merged 1 commit intocloudflare:masterfrom
bobrik merged 1 commit intocloudflare:masterfrom
Conversation
Contributor
Author
|
Heap profile from a problematic instance: Looking with a debugger at another instance: There are definitely fewer than 2 million cgroups on this instance: |
18d9357 to
d34cec7
Compare
With fanotify we see every cgroup appear. Even if there are no metrics associated with it and the cgroup quickly goes away, we keep the mapping in memory. This mostly works fine, until you have an infinite churn of cgroups, then memory starts growing indefinitely. This commit adds a garbage collecting cache that would remove old entries that were not requested in a long time.
d34cec7 to
9e05515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

With fanotify we see every cgroup appear. Even if there are no metrics associated with it and the cgroup quickly goes away, we keep the mapping in memory. This mostly works fine, until you have an infinite churn of cgroups, then memory starts growing indefinitely.
This commit adds a garbage collecting cache that would remove old entries that were not requested in a long time.