feat: Throw by default from failed SQS publish #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `SQSService#publish` throws by default instead of handling errors. To maintain old behaviour, you can pass `"catch"` in the `failureMode` parameter.
This makes more sense logically and also makes the diff cleaner.
|
🎉 This PR is included in version 2.0.0-beta.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sending an SQS message using
SQSServicedoes not throw an error by default. This has caught us out a couple of times where we were expecting a failure. ThefailureModeparameter was added to opt in to throwing errors, to avoid introducing a breaking change in v1.In v2 we'll throw errors by default, and you'll have to opt out of this behaviour.
Jira: ENG-3013
BREAKING CHANGE:
SQSService#publishthrows by default instead of handling errors. To maintain old behaviour, you can pass"catch"in thefailureModeparameter.