ci: Pin Node version in publish job
#1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not clear why this job wasn't already using `actions/setup-node`, but seems that Node 20 is now the default. Setting to Node 18 for consistency with other jobs, for now, so we can unblock that publish. We do need to migrate everything to Node 20+, but as the last publish failure demonstrated, there's an incompatibility with one of the ESLint plugins. We need to resolve this in our ESLint config before we can upgrade here.
curlyfriesplease
approved these changes
Jan 29, 2025
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this failed run: https://github.com/comicrelief/lambda-wrapper/actions/runs/13030440453
Not clear why this job wasn't already using
actions/setup-node, but seems that Node 20 is now the default.Setting to Node 18 for consistency with other jobs, for now, so we can unblock that publish. We do need to migrate everything to Node 20+, but as the last publish failure demonstrated, there's an incompatibility with one of the ESLint plugins. We need to resolve this in our ESLint config before we can upgrade here.