fix: validate new prefix length against old prefix #1938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the target prefix is larger than the placeholder prefix, it would
overwrite into other regions of the binarytruncate the prefix. It would likely lead to broken binaries: https://discord.com/channels/1082332781146800168/1212673297347518464/1450859607072182374Possible issue outside rattler
Being a public function, this function might be being used outside rattler in some valid ways that would now return an error. For example, relocating an environment:
Alternatives
It might be more "rustic" to encode this restriction into a type such as:
instead of accepting any placeholders:
but would be a breaking change in a public function.
Also, it would not solve the relocation use case (for which I have an idea that would
imply changing thenot work after thinking about it some more).info/has_prefixfile, which would be an even bigger breaking change in the conda ecosystem