Skip to content

Fix dependencies#152

Merged
mxpv merged 1 commit intocontainerd:mainfrom
mxpv:dep
Jul 15, 2023
Merged

Fix dependencies#152
mxpv merged 1 commit intocontainerd:mainfrom
mxpv:dep

Conversation

@mxpv
Copy link
Member

@mxpv mxpv commented Jul 11, 2023

Update tempfile version as it was failing for me locally:

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /Users/mxpv/.cargo/registry/src/github.com-1ecc6299db9ec823/rustix-0.36.8/src/lib.rs:99:26
   |
99 | #![cfg_attr(rustc_attrs, feature(rustc_attrs))]
   |                          ^^^^^^^^^^^^^^^^^^^^

and cleanup the old workaround for axum-core

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@mxpv
Copy link
Member Author

mxpv commented Jul 11, 2023

@jsturtevant any thoughts on

---- synchronous::publisher::tests::test_connect stdout ----
thread 'synchronous::publisher::tests::test_connect' panicked at 'called `Result::unwrap()` on an `Err` value: Ttrpc(Windows(231))', crates\shim\src\synchronous\publisher.rs:159:50
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsturtevant
Copy link
Contributor

@jsturtevant any thoughts on

---- synchronous::publisher::tests::test_connect stdout ----
thread 'synchronous::publisher::tests::test_connect' panicked at 'called `Result::unwrap()` on an `Err` value: Ttrpc(Windows(231))', crates\shim\src\synchronous\publisher.rs:159:50
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

231 is all pipe instances are busy might be a flaky test. Has is shown up in other PR's? I will create an issue and see if I can reproduce.

@jsturtevant
Copy link
Contributor

otherwise changes LGTM

@mxpv mxpv merged commit d7ee750 into containerd:main Jul 15, 2023
@mxpv mxpv deleted the dep branch July 15, 2023 00:08
@mxpv mxpv added T-dependencies Pull requests that update a dependency file C-client Containerd client C-snapshots Remote snapshotter C-runc runc helper labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-client Containerd client C-runc runc helper C-snapshots Remote snapshotter T-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants