Skip to content

deps: Update nix crate to latest#204

Closed
bryantbiggs wants to merge 1 commit intocontainerd:mainfrom
bryantbiggs:deps/update-nix
Closed

deps: Update nix crate to latest#204
bryantbiggs wants to merge 1 commit intocontainerd:mainfrom
bryantbiggs:deps/update-nix

Conversation

@bryantbiggs
Copy link
Contributor

  • Update nix crate to latest
    • One of the major changes between 0.26 -> 0.27 is that all features are turned off by default and users need to opt into the features they wish to use

Closes #184

@github-actions github-actions bot added C-runc-shim Runc shim C-shim Containerd shim C-runc runc helper T-CI Changes in project's CI labels Sep 23, 2023
"copy_console: console socket get path: {}, fd: {}",
path, &fds[0]
);
tcgetattr(fds[0])?;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after updating, this was throwing the following error:

error[E0277]: the trait bound `i32: std::os::fd::AsFd` is not satisfied
    --> crates/runc-shim/src/common.rs:209:15
     |
209  |     tcgetattr(fds[0])?;
     |     --------- ^^^^^^ the trait `std::os::fd::AsFd` is not implemented for `i32`
     |     |
     |     required by a bound introduced by this call
     |

Looking into the docs, it looks like the current implementation is a no-op since tcsetattr() is never called on the structure https://github.com/nix-rust/nix/blob/996db47d542ae20f09eb344b9fcb88c40ae38e3d/src/sys/termios.rs#L1156-L1158

@bryantbiggs
Copy link
Contributor Author

will need to think about this more

@bryantbiggs bryantbiggs deleted the deps/update-nix branch September 23, 2023 16:53
@mxpv mxpv mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-runc runc helper C-runc-shim Runc shim C-shim Containerd shim T-CI Changes in project's CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant