deps: Update nix crate to latest#204
Closed
bryantbiggs wants to merge 1 commit intocontainerd:mainfrom
Closed
Conversation
bryantbiggs
commented
Sep 23, 2023
| "copy_console: console socket get path: {}, fd: {}", | ||
| path, &fds[0] | ||
| ); | ||
| tcgetattr(fds[0])?; |
Contributor
Author
There was a problem hiding this comment.
after updating, this was throwing the following error:
error[E0277]: the trait bound `i32: std::os::fd::AsFd` is not satisfied
--> crates/runc-shim/src/common.rs:209:15
|
209 | tcgetattr(fds[0])?;
| --------- ^^^^^^ the trait `std::os::fd::AsFd` is not implemented for `i32`
| |
| required by a bound introduced by this call
|Looking into the docs, it looks like the current implementation is a no-op since tcsetattr() is never called on the structure https://github.com/nix-rust/nix/blob/996db47d542ae20f09eb344b9fcb88c40ae38e3d/src/sys/termios.rs#L1156-L1158
5434310 to
ec0f06c
Compare
Contributor
Author
|
will need to think about this more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nixcrate to latest0.26->0.27is that all features are turned off by default and users need to opt into the features they wish to useCloses #184