Skip to content

.github/workflows/ci: add machete to CI#319

Merged
mxpv merged 3 commits intocontainerd:mainfrom
Mossaka:add-machete-to-ci
Nov 6, 2024
Merged

.github/workflows/ci: add machete to CI#319
mxpv merged 3 commits intocontainerd:mainfrom
Mossaka:add-machete-to-ci

Conversation

@Mossaka
Copy link
Member

@Mossaka Mossaka commented Sep 30, 2024

this will check if there are unused deps in this repo

@github-actions github-actions bot added the T-CI Changes in project's CI label Sep 30, 2024
@Mossaka Mossaka closed this Oct 3, 2024
@Mossaka Mossaka reopened this Oct 3, 2024
@mxpv
Copy link
Member

mxpv commented Oct 4, 2024

Try rebase?

@Mossaka
Copy link
Member Author

Mossaka commented Oct 4, 2024

Ah the issue was not about rebase. The error from cargo machete says

containerd-snapshots -- ./crates/snapshots/Cargo.toml:
	prost
containerd-client -- ./crates/client/Cargo.toml:
	prost

we probably want to ignore prost dependency as it's actually being used.

@github-actions github-actions bot added C-client Containerd client C-snapshots Remote snapshotter labels Oct 21, 2024
@mxpv mxpv added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@mxpv mxpv added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@Mossaka
Copy link
Member Author

Mossaka commented Nov 5, 2024

Can we merge this PR? @mxpv

@mxpv mxpv added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@mxpv
Copy link
Member

mxpv commented Nov 5, 2024

@Mossaka could you pls rebase against latest main? Looks like there is a CI issue that needs to be addressed first.

@Mossaka
Copy link
Member Author

Mossaka commented Nov 5, 2024

Looks like I need to rebase this one

this will check if there are unused deps in this repo
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
Signed-off-by: jiaxiao zhou <duibao55328@gmail.com>
@github-actions github-actions bot added the C-runc runc helper label Nov 5, 2024
@mxpv mxpv added this pull request to the merge queue Nov 6, 2024
Merged via the queue into containerd:main with commit 857ace0 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-client Containerd client C-runc runc helper C-snapshots Remote snapshotter needs update T-CI Changes in project's CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants