fix os_pipe doesn't work with async IO#326
Merged
mxpv merged 1 commit intocontainerd:mainfrom Oct 21, 2024
Merged
Conversation
mxpv
approved these changes
Oct 21, 2024
Member
|
It looks like this PR broke the runc crate when Repro$ cargo build -p runc
Compiling runc v0.2.0 (/home/mossaka/developer/spinkube/rust-extensions-fork/crates/runc)
error[E0433]: failed to resolve: use of undeclared crate or module `tokio`
--> crates/runc/src/io.rs:34:5
|
34 | use tokio::net::unix::pipe;
| ^^^^^ use of undeclared crate or module `tokio`
error[E0277]: the trait bound `OwnedFd: std::io::Write` is not satisfied
--> crates/runc/src/io.rs:165:26
|
165 | .map(|x| Box::new(x) as Box<dyn Write + Send + Sync>)
| ^^^^^^^^^^^ the trait `std::io::Write` is not implemented for `OwnedFd`
|
= note: required for the cast from `std::boxed::Box<OwnedFd>` to `std::boxed::Box<dyn std::io::Write + Send + Sync>`
error[E0277]: the trait bound `OwnedFd: std::io::Read` is not satisfied
--> crates/runc/src/io.rs:185:26
|
185 | .map(|x| Box::new(x) as Box<dyn Read + Send>)
| ^^^^^^^^^^^ the trait `std::io::Read` is not implemented for `OwnedFd`
|
= note: required for the cast from `std::boxed::Box<OwnedFd>` to `std::boxed::Box<dyn std::io::Read + Send>`
error[E0277]: the trait bound `OwnedFd: std::io::Read` is not satisfied
--> crates/runc/src/io.rs:205:26
|
205 | .map(|x| Box::new(x) as Box<dyn Read + Send>)
| ^^^^^^^^^^^ the trait `std::io::Read` is not implemented for `OwnedFd`
|
= note: required for the cast from `std::boxed::Box<OwnedFd>` to `std::boxed::Box<dyn std::io::Read + Send>` |
Member
|
hmm, that's bad. Do you want to open a PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix oconnor663/os_pipe.rs#35