Consolidate the Windows NamedPipeLogger into the FifoLogger#382
Merged
mxpv merged 1 commit intocontainerd:mainfrom Mar 19, 2025
Merged
Consolidate the Windows NamedPipeLogger into the FifoLogger#382mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
601f874 to
7c26aec
Compare
Contributor
Author
|
@mxpv PTAL |
mxpv
approved these changes
Mar 14, 2025
Contributor
Author
|
Is this ready to merge? |
Member
|
@jprendes the PR looks good. It looks like the CI is broken because of some other issue, I'll try to have a look soon. |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
7c26aec to
32f4104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a fair amount of duplicated code between both loggers.
Given that we can treat the named pipe as a
std::fs::File, we can consolidate the functionality of both.This PR:
sysmodule with theNamedPipeLoggerNamedPipeLoggerfunctionality as a newwith_named_pipemethod in theFifoLogger.NamedPipeLoggertests to theFifoLoggermoduleFifoLogger::newso that it can construct the windows logger.