Use same activation strategy in all platforms#383
Merged
mxpv merged 3 commits intocontainerd:mainfrom Mar 19, 2025
Merged
Conversation
Contributor
Author
|
@mxpv , PTAL |
Mossaka
approved these changes
Mar 19, 2025
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
mxpv
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the sync code uses two different activation strategies:
This PR unified the activation strategy on all platforms, following the strategy used for Windows.
Additionally, it avoids computing the listener address twice by reusing the
-socketflag when spawning the child process.This PR also applies the same activation strategy to the async code.
The main motivation for this PR is to eventually support Windows on the async feature.