Merged
Conversation
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Contributor
Author
|
@mxpv PTAL :-) |
Mossaka
approved these changes
Mar 19, 2025
mxpv
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to unblock CI, which is currently failing.
This bumps the deny.toml file to the new format, and adds
proc-macro-errorandprotobufadvisories to the ignore list.proc-macro-erroris marked as unmaintained, and is not a direct dependencies ofrust-extensions. It should be fixed upstream.protobufis a direct dependency ofrust-extensions, but bumping the dependency here does not fix the issue, asttrcp-codegenstill depends on an older version ofprotobuf.In my opinion, in the case of
protobuf, this should be considered a temporary solution, and we should work with upstream to fix the underlying issue.