shim/loop-dev: fix variable undefined error for musl#414
Merged
mxpv merged 1 commit intocontainerd:mainfrom Jul 18, 2025
Merged
shim/loop-dev: fix variable undefined error for musl#414mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
Fixes: containerd#413 Signed-off-by: Tim Zhang <tim@hyper.sh>
0b9ffdf to
66edbe6
Compare
Member
Author
|
@zzzzzzzzzy9 Can you help me out with the unit test |
Member
Author
|
The unit test problem existed before the PR. This PR fixed the bug and exposes the existing problem. |
Closed
fidencio
approved these changes
Jul 18, 2025
Collaborator
fidencio
left a comment
There was a problem hiding this comment.
lgtm, thanks @Tim-Zhang!
It does solve the build issue on musl. Just keep in mind that I'm not a maintainer here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #413