CMAEntry Serialization During Entry Creation#174
Merged
Rafal Niski (rafalniski) merged 20 commits intocontentful:masterfrom Mar 19, 2024
Xchg0x5f375d:master
Merged
CMAEntry Serialization During Entry Creation#174Rafal Niski (rafalniski) merged 20 commits intocontentful:masterfrom Xchg0x5f375d:master
Rafal Niski (rafalniski) merged 20 commits intocontentful:masterfrom
Xchg0x5f375d:master
Conversation
# Conflicts: # src/main/java/com/contentful/java/cma/CMAClient.java
src/main/java/com/contentful/java/cma/gson/MetadataSerializer.java
Outdated
Show resolved
Hide resolved
Rafal Niski (rafalniski)
requested changes
Mar 19, 2024
Collaborator
Rafal Niski (rafalniski)
left a comment
There was a problem hiding this comment.
One styling comment
Rafal Niski (rafalniski)
approved these changes
Mar 19, 2024
Collaborator
Rafal Niski (rafalniski)
left a comment
There was a problem hiding this comment.
LGTM, good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR attempts to resolve the issue of missing metadata properties upon CMAEntry creation.
Why?
See this discussion.
How?
Created a new MetadataSerializer that at the moment includes
tagsproperty in serialization process, and then extended EntrySerialization to includemetadataserialization.Testing
Ran the unit test and confirmed it passes.
There are a few ways this could be refactored. Let me know if you have any other questions or feedback! I'd be more than happy to see this improvement merged.
Closes #173