Support wrapping of Preset::Provider inside cgp_preset! macro#103
Merged
soareschen merged 8 commits intomainfrom Jun 1, 2025
Merged
Support wrapping of Preset::Provider inside cgp_preset! macro#103soareschen merged 8 commits intomainfrom
Preset::Provider inside cgp_preset! macro#103soareschen merged 8 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the user to specify a
#[wrap_provider]attribute in thecgp_preset!macro, to wrap thePreset::Providertype around the wrapper type.Motivation
CGP presets can be used not just for wiring CGP components, but also to define extensible mappings to be used for generic dispatch through the
UseDelegatepattern.Without the provider wrapping, it becomes tedious to extend the non-provider mapping across multiple levels of preset inheritance. This is because the values in the maps are still expected to implement the provider trait, but the non-wrapped mapping type does not implement the provider trait.
With the wrapper, the
Preset::Providertype would implement the expected provider trait through the wrapper, making it a valid delegation target when a child preset inherits from it.Example
Given the following preset definition:
The macro would generate the following implementation: