Refactoring and Improvements on #[cgp_getter]#81
Merged
soareschen merged 19 commits intomainfrom Mar 23, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings several quality of life improvements on the proc macros
#[cgp_getter]and#[cgp_auto_getter], allowing them to support more general getter interfaces to be defined.Specialized
&strFieldGetter methods can now return
&strinstead of&Stringto deriveUseFieldimplementations that require the context to contain aStringfield.For example, the following
HasNametrait will be implemented for any context struct that containsname: String:Specialized
Option<&T>FieldGetter methods can now return
Option<&T>instead of&Option<T>to deriveUseFieldimplementations that require the context to contain anOption<T>field.For example, the following
HasNametrait will be implemented for any context struct that containsname: Option<Self::Name>:Specialized
Cloneeable FieldGetter methods can now return owned values instead of references. The derived implementation will require the value type to implement
Clone.For example, the following
HasNametrait will be implemented for any context struct that containsname: Self::NamewithSelf::Name: Clone:PhantomDataTag ArgumentA second
PhantomDataargument can now be provided in getter methods to help with type inferences, in case when the getter trait contains generic parameters.Example:
WithFieldRefA
UseFieldRefprovider has been implemented as a complement ofUseField, which allows accessing a field value usingAsRef. This allows field accessors to be implemented on structs that do not contain the exact same type, such as values that are wrapped inBoxorArc.For example, the following
Personcontext implementsHasNamethat returnsString, even though the context contains anamefield of typeBox<String>: