cli: Include recommended solana args by default and add new --max-retries #3354
Conversation
|
@Serdnad is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
Any other flags we should include by default? |
There was a problem hiding this comment.
Any other flags we should include by default?
--use-quicmaybe? And separately, would it make sense to also add--max-retriestoanchor deploy
Afaik --use-rpc is more consistent but also depends on the RPC provider. I think increasing maximum retries makes sense though (changing the max sign attempts to 30 like you've done should take care of it).
ca8ed81
to
dbe1ee4
Compare
|
Sorry for the wait, fixed the clippy lints and updated the changelog |
| @@ -30,6 +30,7 @@ The minor version will be incremented upon a breaking change and the patch versi | |||
| - idl: Remove `anchor-syn` dependency ([#3030](https://github.com/coral-xyz/anchor/pull/3030)). | |||
| - lang: Add `const` of program ID to `declare_id!` and `declare_program!` ([#3019](https://github.com/coral-xyz/anchor/pull/3019)). | |||
| - idl: Add separate spec crate ([#3036](https://github.com/coral-xyz/anchor/pull/3036)). | |||
| - cli: Include recommended solana args by default and add new --max-retries ([#3354](https://github.com/coral-xyz/anchor/pull/3354)). | |||
There was a problem hiding this comment.
Sorry for the wait, fixed the clippy lints and updated the changelog
Thanks but this is the incorrect one to update (v0.30.1 is already out, this will be included in v0.31.0). Please revert this change and update it in the place that was linked in #3354 (review)
This PR includes the two following changes. They were closely related and small enough that 1 PR seemed reasonable, but happy to split them up if requested.
Updates
anchor deployandanchor upgradeto use default values for the following args, if not supplied:--with-compute-unit-price: defaults to the median unit price of recent successful transaction--max-sign-attempts: a somewhat arbitrary, but fairly practical value of 30--buffer: creates a new buffer keypair in the OS' default tmp directory on first use, and reuses thatAdds a new top-level, optional arg
--max-retriestoanchor upgrade, which will retry the upgrade with the same args. This is primarily useful for inconsistent issues like "Invalid Blockhash" or "N write transactions failed", which often just require another attempt.