Closed
Conversation
Explicitly orders by asset.size just in case users have a field with a handle of `size`
b456434 to
2e82be5
Compare
brandonkelly
added a commit
that referenced
this pull request
Feb 9, 2023
Member
|
This feels a little too lighthanded. It solves this one guy’s problem, but the same could still happen from any of the other asset-specific sortable attributes that don’t specify the table name in So I just beefed up element queries’ automatic column name mapping for 4.4 via 74211f8. Going forward, all element extension table columns will be included automatically from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explicitly orders by
asset.sizejust in case users have a field with a handle ofsize. Reserved handles don't help us here because thecolumnMapused byorderByuses all columns on thecontenttable, so any entry type with afieldHandleofsizewill cause issues.Related issues
Fixes #12652