Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CD build stage tweaks #4

Merged
merged 10 commits into from
Aug 27, 2024
Merged

More CD build stage tweaks #4

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
35ae04f
Add docker build and CI job
ml-evs Aug 27, 2024
e83ca60
Fix tags
ml-evs Aug 27, 2024
2ff88aa
Get rid of GHA environment
ml-evs Aug 27, 2024
5848376
Split job into build then push
ml-evs Aug 27, 2024
0acb1d1
Fix Docker build tags
ml-evs Aug 27, 2024
3fc20c4
Scrap environment
ml-evs Aug 27, 2024
36ae70a
Rename build steps
ml-evs Aug 27, 2024
ccf4a61
Tag PR images too, to avoid double counting
ml-evs Aug 27, 2024
94e7961
Merge branch 'main' into ml-evs/docker
ml-evs Aug 27, 2024
1ba0701
Linting
ml-evs Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Get rid of GHA environment
  • Loading branch information
@ml-evs
ml-evs committed Aug 27, 2024
commit 2ff88aad582968f95994723a41d1d7c341afc46c
4 changes: 0 additions & 4 deletions .github/workflows/build_container.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ jobs:
if: github.repository_owner == 'datalab-org'
runs-on: ubuntu-latest

environment:
name: container-image
url: https://github.com/${{ github.repository }}/pkgs/container/${{ vars.IMAGE_NAME }}

steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down