Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Login Splash Screen #907

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add Login Splash Screen #907

wants to merge 3 commits into from

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #767

  • Login splash screen that displays the login options (GitHub, ORCID, and email)
  • Updated route handling to redirect unauthenticated users to the /login page, with the exception of the /about page, which remains accessible without authentication.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (39be3fb) to head (7148186).
Report is 86 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          62       62           
  Lines        3909     3909           
=======================================
  Hits         2667     2667           
  Misses       1242     1242           

Copy link

cypress bot commented Oct 4, 2024

datalab    Run #2485

Run Properties:  status check failed Failed #2485  •  git commit 1e9ee94c49 ℹ️: Merge 7148186ab79d792a13999b2fc3bb0006521ea550 into 39be3fb056179b66d37cf2de259a...
Project datalab
Branch Review bc/login-screen
Run status status check failed Failed #2485
Run duration 09m 59s
Commit git commit 1e9ee94c49 ℹ️: Merge 7148186ab79d792a13999b2fc3bb0006521ea550 into 39be3fb056179b66d37cf2de259a...
Committer Benjamin Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 132
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  batchSampleFeature.cy.js • 17 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > Adds 3 valid samples Test Replay Screenshots
Batch sample creation > adds two valid samples Test Replay Screenshots
Batch sample creation > adds four base samples Test Replay Screenshots
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > makes samples copied from others Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > creates samples using components Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id Test Replay Screenshots
The first 10 failed tests are shown, see all 17 tests in Cypress Cloud.
Failed  editPage.cy.js • 9 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Loads the main page without any errors Test Replay Screenshots
Edit Page > Adds a valid sample Test Replay Screenshots
Edit Page > Add some more samples, to use as components Test Replay Screenshots
Edit Page > Checks editing the sample edit page Test Replay Screenshots
Edit Page > adds a chemical formula to component1 Test Replay Screenshots
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Failed  equipment.cy.js • 8 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Equipment table page > Loads the equipment page without any errors Test Replay Screenshots
Equipment table page > Adds some valid equipment entries Test Replay Screenshots
Equipment table page > Checks if one of the equipment items is in the database Test Replay Screenshots
Equipment table page > Attempts to Add an item with the same name Test Replay Screenshots
Equipment table page > Deletes an item Test Replay Screenshots
Equipment table page > copies an equipment entry Test Replay Screenshots
Equipment edit page > Checks the equipment edit page Test Replay Screenshots
Equipment edit page > modifies some data in a sample Test Replay Screenshots
Failed  sampleTablePage.cy.js • 10 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Advanced sample creation features > Adds some valid samples Test Replay Screenshots
Advanced sample creation features > Adds a third sample copied from the first Test Replay Screenshots
Advanced sample creation features > deletes the first sample and makes sure the copy is still there Test Replay Screenshots
Advanced sample creation features > makes some more items for testing as components Test Replay Screenshots
Advanced sample creation features > modifies some data in the second sample Test Replay Screenshots
Advanced sample creation features > copies the second sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample Test Replay Screenshots
Advanced sample creation features > copies the copied sample, this time with additional components Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Test Replay Screenshots
Advanced sample creation features > selects a sample by checkbox, adds it to a new collection, then checks the collections page Test Replay Screenshots
Failed  batchSampleFeature.cy.js • 17 failed tests • End-to-end tests (firefox)

View Output

Test Artifacts
Batch sample creation > Adds 3 valid samples Screenshots
Batch sample creation > adds two valid samples Screenshots
Batch sample creation > adds four base samples Screenshots
Batch sample creation > modifies some data in the first sample Screenshots
Batch sample creation > modifies some data in the second sample Screenshots
Batch sample creation > makes samples copied from others Screenshots
Batch sample creation > checks the copied samples Screenshots
Batch sample creation > creates samples using components Screenshots
Batch sample creation > checks the created samples Screenshots
Batch sample creation > uses the template id Screenshots
The first 10 failed tests are shown, see all 17 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.

Copy link
Contributor Author

@BenjaminCharmes BenjaminCharmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A (very quick) first draft to give an idea of what it might look like.
I really have no idea at the moment, so I'll try to make few different ones.
If you have any ideas, or even examples of things you might like, don't hesitate to send them to me.

Feedback are more than welcome!

Screenshot 2024-10-04 at 14 39 52

@BenjaminCharmes
Copy link
Contributor Author

BenjaminCharmes commented Oct 4, 2024

Another one.

Screenshot 2024-10-04 at 15 27 45

@BenjaminCharmes
Copy link
Contributor Author

Another one

Screenshot 2024-10-04 at 15 44 54

@ml-evs
Copy link
Member

ml-evs commented Oct 4, 2024

Some combination of 1+2 would be nice! A central box, perhaps split into two with a datalab logo/title at the top left and a bit of text, then the login buttons in a box on the right under the grey-group logo.

I think ultimately we need to think about what the top section of the table page should look like; I've tried adding more datalab logo-ish stuff to it in the past, but struggled to make it look good.

@ml-evs
Copy link
Member

ml-evs commented Oct 4, 2024

I would suggest that we now you've thrown together the logic side of it, we can play around with designs in canva/inkscape or something. Could you upload an svg of these screens so we can drag stuff around?

@BenjaminCharmes
Copy link
Contributor Author

BenjaminCharmes commented Oct 8, 2024

Something more like this ?

Screenshot 2024-10-08 at 11 56 21

If you have some datalab logo that you like, you can send me them and I can try to do something for the table page if you want.

@BenjaminCharmes BenjaminCharmes added webapp For issues/PRs pertaining to the web interface design-discussion For issues describing broader design decisions and functionality. labels Oct 8, 2024
@ml-evs ml-evs added this to the v0.6.x milestone Oct 14, 2024
@ml-evs ml-evs added the blocked label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked design-discussion For issues describing broader design decisions and functionality. webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Replace default unauthenticated page with a login splash screen
2 participants