-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Login Splash Screen #907
base: main
Are you sure you want to change the base?
Conversation
c3369f4
to
f4d6012
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 68.22% 68.22%
=======================================
Files 62 62
Lines 3909 3909
=======================================
Hits 2667 2667
Misses 1242 1242 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some combination of 1+2 would be nice! A central box, perhaps split into two with a datalab logo/title at the top left and a bit of text, then the login buttons in a box on the right under the grey-group logo. I think ultimately we need to think about what the top section of the table page should look like; I've tried adding more datalab logo-ish stuff to it in the past, but struggled to make it look good. |
I would suggest that we now you've thrown together the logic side of it, we can play around with designs in canva/inkscape or something. Could you upload an svg of these screens so we can drag stuff around? |
Closes #767