Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1a99509
both dockerfiles are now pushed to docker hub, the smaller will repla…
PavolStefanec Oct 9, 2025
a0d0df0
Update .github/workflows/docker.yml
pStefanec Oct 15, 2025
3c05d2d
Merge pull request #1036 from dataquest-dev/ufal/minify_docker_image_…
pStefanec Oct 15, 2025
f58c08c
Skipping customer/uk branch in triggering playwright tests (#1049)
Kasinhou Oct 17, 2025
38e8910
UFAL/Synchronization of en.json5 and cs.json5 (#1037)
Kasinhou Oct 17, 2025
b8f1d94
frontend will get filtered version of config.json without sensitive i…
PavolStefanec Oct 28, 2025
31cfcd2
fix auth property exposure
PavolStefanec Oct 28, 2025
adec4db
access to nested properties could cause runtime errors...
PavolStefanec Oct 28, 2025
1a03fea
even more specific config filtering
PavolStefanec Oct 28, 2025
35ce442
Using a conditional spread
pStefanec Oct 28, 2025
6d7ee07
Using a conditional spread
pStefanec Oct 28, 2025
997b691
Using a conditional spread
pStefanec Oct 28, 2025
4632d71
missing comma
pStefanec Oct 28, 2025
8423f0f
We used *.dist dockerfile and the `dspace-ui.json` is on /app/dspace-…
milanmajchrak Oct 28, 2025
1fa478b
Merge pull request #1059 from dataquest-dev/filter_exposed_config
pStefanec Oct 28, 2025
4b42261
UFAL/Added space to title (#1070)
Kasinhou Oct 30, 2025
ffef6cf
permissions for non root user
PavolStefanec Oct 15, 2025
2b2836d
attempted permissions fix
PavolStefanec Oct 15, 2025
f60c662
workflow fix
PavolStefanec Oct 15, 2025
0d87f97
missing folder fix
PavolStefanec Oct 15, 2025
5b8270b
useless commit
PavolStefanec Oct 15, 2025
1b6a90e
remove empty line
PavolStefanec Oct 15, 2025
566775e
fixing permissions issue
PavolStefanec Oct 15, 2025
8b46f94
comment for clarity
pStefanec Oct 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ jobs:
# Use the reusable-docker-build.yml script from DSpace/DSpace repo to build our Docker image
uses: dataquest-dev/DSpace/.github/workflows/reusable-docker-build.yml@dtq-dev
with:
build_id: dspace-angular
build_id: dspace-angular-dev
image_name: dataquest/dspace-angular
dockerfile_path: ./Dockerfile
tags_flavor: suffix=-dev
# As this is a "dev" image, its tags are all suffixed with "-dev". Otherwise, it uses the same
# tagging logic as the primary 'dspace/dspace-angular' image above.
run_python_version_script: true
python_version_script_dest: src/static-files/VERSION_D.html
secrets:
Expand All @@ -42,16 +45,13 @@ jobs:
#############################################################
dspace-angular-dist:
# Ensure this job never runs on forked repos. It's only executed for 'dataquest/dspace-angular'
if: github.repository == 'dataquest-dev/dspace-angular' && false # not used for now
if: github.repository == 'dataquest-dev/dspace-angular'
# Use the reusable-docker-build.yml script from DSpace/DSpace repo to build our Docker image
uses: dataquest-dev/DSpace/.github/workflows/reusable-docker-build.yml@dtq-dev
with:
build_id: dspace-angular-dist
image_name: dspace/dspace-angular
build_id: dspace-angular
image_name: dataquest/dspace-angular
dockerfile_path: ./Dockerfile.dist
# As this is a "dist" image, its tags are all suffixed with "-dist". Otherwise, it uses the same
# tagging logic as the primary 'dspace/dspace-angular' image above.
tags_flavor: suffix=-dist
run_python_version_script: true
python_version_script_dest: src/static-files/VERSION_D.html
secrets:
Expand All @@ -69,4 +69,4 @@ jobs:
with:
INSTANCE: '5'
IMPORT: false
secrets: inherit
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/trigger-ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

git fetch --prune origin
BRANCHES=$(git ls-remote --heads origin | awk -F'/' '{print $3"/"$4}' | grep '^customer/')
SKIP_BRANCHES=("customer/sav")
SKIP_BRANCHES=("customer/sav" "customer/uk")

for branch in $(echo "$BRANCHES" | sed -e 's/[\[\]"]//g' -e 's/,/\n/g'); do
if [[ " ${SKIP_BRANCHES[@]} " =~ " ${branch} " ]]; then
Expand Down
11 changes: 11 additions & 0 deletions Dockerfile.dist
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ COPY package.json yarn.lock ./
RUN yarn install --network-timeout 300000

ADD . /app/

# Set memory limit for build process - Angular builds require more memory
ENV NODE_OPTIONS="--max_old_space_size=4096"
RUN yarn build:prod

FROM node:18-alpine
Expand All @@ -24,6 +27,14 @@ COPY --chown=node:node --from=build /app/dist /app/dist
COPY --chown=node:node config /app/config
COPY --chown=node:node docker/dspace-ui.json /app/dspace-ui.json

# user node does not have root priviliges sop we need to ensure that
# necessary files exist and node has sufficient access rights
RUN mkdir -p /app/dist/browser/assets \
&& touch /app/dist/browser/assets/config.json \
&& chown -R node:node /app/dist/browser/assets \
&& chmod -R 755 /app/dist/browser/assets \
&& chmod 664 /app/dist/browser/assets/config.json

WORKDIR /app
USER node
ENV NODE_ENV=production
Expand Down
2 changes: 1 addition & 1 deletion docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ services:
dockerfile: Dockerfile
networks:
dspacenet:
entrypoint: ${FE_CMD:-/bin/sh -c "pm2-runtime start docker/dspace-ui.json > /dev/null 2> /dev/null"}
entrypoint: ${FE_CMD:-/bin/sh -c "pm2-runtime start dspace-ui.json > /dev/null 2> /dev/null"}
ports:
- published: 400${INSTANCE}
target: 4000
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/metadata/metadata.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ export class MetadataService {
const titlePrefix = this.translate.get('repository.title.prefix');
const title = this.translate.get(routeInfo.data.value.title, routeInfo.data.value);
combineLatest([titlePrefix, title]).pipe(take(1)).subscribe(([translatedTitlePrefix, translatedTitle]: [string, string]) => {
this.addMetaTag('title', translatedTitlePrefix + translatedTitle);
this.title.setTitle(translatedTitlePrefix + translatedTitle);
this.addMetaTag('title', translatedTitlePrefix + ' ' + translatedTitle);
this.title.setTitle(translatedTitlePrefix + ' ' + translatedTitle);
});
}
if (routeInfo.data.value.description) {
Expand Down
Loading
Loading