Skip to content

UFAL/Fix the bulk access #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 4 commits into from
May 14, 2025
Merged

UFAL/Fix the bulk access #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
060b54b
Do not use the clarin item view box for the bulk access
milanmajchrak May 7, 2025
aa85b4e
Removed unused import
milanmajchrak May 7, 2025
9c3b843
Clarify the `showClarinViewBox` is boolean
milanmajchrak May 13, 2025
0f668fa
Use the constant for the hardcoded bulk access list id
milanmajchrak May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/shared/object-list/object-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
(prev)="goPrev()"
(next)="goNext()">
<ul *ngIf="objects?.hasSucceeded" class="list-unstyled" [ngClass]="{'ml-4': selectable}">
<div *ngIf="context === 'search'">
<div *ngIf="showClarinViewBox()">
<ds-clarin-item-box-view
*ngFor="let object of objects?.payload?.page; let i = index; let last = last"
[object]="object"
[isSearchResult]="true">
</ds-clarin-item-box-view>
</div>
<div *ngIf="context !== 'search'">
<div *ngIf="!showClarinViewBox()">
<li *ngFor="let object of objects?.payload?.page; let i = index; let last = last" class="mt-4 mb-4 d-flex" [class.border-bottom]="hasBorder && !last" [attr.data-test]="'list-object' | dsBrowserOnly">
<ds-selectable-list-item-control *ngIf="selectable" [index]="i"
[object]="object"
Expand Down
11 changes: 11 additions & 0 deletions src/app/shared/object-list/object-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ import { CollectionElementLinkType } from '../object-collection/collection-eleme
animations: [fadeIn]
})
export class ObjectListComponent {
/**
* The id of the list used for bulk access
*/
BULK_ACCESS_LIST_ID = 'bulk-access-list';

/**
* The view mode of the this component
*/
Expand Down Expand Up @@ -227,4 +232,10 @@ export class ObjectListComponent {
this.next.emit(true);
}

/**
* Show the search results in the Clarin view box or use the default view
*/
showClarinViewBox(): boolean {
return this.context === 'search' && this.selectionConfig?.listId !== this.BULK_ACCESS_LIST_ID;
}
}