Skip to content

UFAL/Searching problems in Manage Handles table #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 10 commits into from
Jun 20, 2025
Merged

UFAL/Searching problems in Manage Handles table #882

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f6cc5ea
locked searchbar when searchOption is not picked
jr-rk Jun 20, 2025
a1543f8
edited Resource Type search option to not be case-sensitive
jr-rk Jun 20, 2025
9a93209
edited Resource Type search option to show nothing when there is no m…
jr-rk Jun 20, 2025
eda80a9
try to set lowercase constants without toLowerCase method
jr-rk Jun 20, 2025
b119487
Revert "try to set lowercase constants without toLowerCase method"
jr-rk Jun 20, 2025
d2eb8a4
changed the heading of Internal search option
jr-rk Jun 20, 2025
b0f91ae
refactored - copilots hint to rephrase condition
jr-rk Jun 20, 2025
4dc0f2b
Added full list of handles for empty Resource Type search option
jr-rk Jun 20, 2025
5989aa0
refactored empty searchQueries handling and added comment for invalid…
jr-rk Jun 20, 2025
75c4317
removed unimportant default switch
jr-rk Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactored - copilots hint to rephrase condition
  • Loading branch information
@jr-rk
jr-rk committed Jun 20, 2025
commit b0f91ae50b2c9ef36f323c426239d55225d4bf31
2 changes: 1 addition & 1 deletion src/app/handle-page/handle-table/handle-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h5 class="card-header">{{ 'handle-table.title' | translate }}</h5>
</div>
<input type="text" id="clarin-dc-search-box" class="form-control" aria-label="Text input with dropdown button"
[(ngModel)]="searchQuery"
[disabled]="searchOption == null || searchOption == ''">
[disabled]="!searchOption">
<span class="input-group-append" (click)="searchHandles()">
<button type="submit" class="btn btn-primary search-button">
<i class="fas fa-search"></i>{{'handle-table.dropdown.search-button' | translate}}</button>
Expand Down