Trigger playwright tests only for running customers #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe workflow script responsible for triggering UI tests on customer branches was updated to introduce a branch filter. Three specific branches are now excluded from triggering UI tests by checking against a new skip list before proceeding. Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant Branches
participant UI_Tests
Workflow->>Branches: Iterate over customer branches
alt Branch in SKIP_BRANCHES
Workflow->>Workflow: Output skip message, continue
else Branch not in SKIP_BRANCHES
Workflow->>UI_Tests: Trigger UI tests for branch
end
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/trigger-ui-tests.yml (2)
27-27: Avoid hard-coding skip list – externalise or parametrize for maintainability
A hard-coded array requires a code change each time a branch is added/removed. Pulling the list from an environment variable, repository secret, or small YAML/JSON file keeps the workflow self-service and avoids unnecessary PRs.
28-34: Remove trailing whitespace to satisfy YAML-lint
Lines 28 and 34 contain stray spaces flagged by YAML-lint. Clean them up to keep the workflow lint-clean.- SKIP_BRANCHES=("customer/sav" "customer/vsb-tuo" "customer/zcu-data") - + SKIP_BRANCHES=("customer/sav" "customer/vsb-tuo" "customer/zcu-data")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/trigger-ui-tests.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Kasinhou
PR: dataquest-dev/dspace-angular#905
File: .github/workflows/automated-manual-tests.yml:24-33
Timestamp: 2025-07-09T12:50:03.144Z
Learning: In the dspace-angular project, customer-specific GitHub workflow files like `.github/workflows/automated-manual-tests.yml` are maintained separately in each customer branch with hard-coded values appropriate for that customer, rather than using parameterized workflows. This allows each customer branch to have its own configuration while avoiding the complexity of workflow parameterization.
.github/workflows/trigger-ui-tests.yml (1)
Learnt from: Kasinhou
PR: dataquest-dev/dspace-angular#905
File: .github/workflows/automated-manual-tests.yml:24-33
Timestamp: 2025-07-09T12:50:03.144Z
Learning: In the dspace-angular project, customer-specific GitHub workflow files like `.github/workflows/automated-manual-tests.yml` are maintained separately in each customer branch with hard-coded values appropriate for that customer, rather than using parameterized workflows. This allows each customer branch to have its own configuration while avoiding the complexity of workflow parameterization.
🪛 YAMLlint (1.37.1)
.github/workflows/trigger-ui-tests.yml
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 34-34: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: dspace-angular / docker-build (linux/amd64, ubuntu-latest, true)
- GitHub Check: tests (16.x)
- GitHub Check: tests (18.x)
milanmajchrak
approved these changes
Jul 14, 2025
milanmajchrak
added a commit
that referenced
this pull request
Jul 24, 2025
* Removed dynamic overflow because every content must be scrollable.. (#716) * add tar for preview (#713) * add tar for preview * UFAL/Enhanced type-bind feature (#714) * The type-bind is loaded from the cfg and correctly rendered * Done some refactoring * Update tests following the type-bind enhancement * Fixed linting error. * Removed unwanted changes and fixed wrong refactored code. * Updated error message when tests failed * Update README.md * UFAL/Show sesznam license on approval page (#722) * Added static files from the SEZNAM license. * Refactored fetching html content from the static files. The logic was moved into the common service. * Show Seznam static license on approval page. * Updated constant name LICENSE_NAME_SEZNAM - added the _CZ to make it more clear that is Czech license * UFAL/share submission by email (#720) * Added share submission button into workspaceitem actions page. * Added notification about the success of the sharing the submission. * Created share submission module, page with routing. That page could access only the administrator. * WIP - created a new page `change-submitter-page`. * Created page when the user could take the workspace item as its own. * Pretified the code and added some docs * Updated tests following the new feature * Fixed unwanted changes, updated docs * UFAL/Autocomplete enhancement (#718) * Added support for searching results from specific solr indexes. Updated autocomplete component to search values from custom solr index. The autocomplete component could have attribute for resolving the custom index from the submission-forms definition. * Show suggestions for `solr-handle_title_ac` and `solr-subject_ac` * Fixed tests * Formatted language suggestions, added docs and fixed tests. * Refactored the code following the review requirements. * Fixed type in the word pretify * UFAL/License page - wrong layout in Firefox (#721) * Removed flex class and used width style instead of col * Removed unsued class * Changed style in the html into classes * Migrated Vanilla cs messages into clarin 7.6.1. cs messages (#669) * Migrated Vanilla cs messages into clarin 7.6.1. cs messages * updated translation * Updated cs localization for subcommunities and subcollections * Changed `prispeveku` to `prispevku` * Updated messages for the 'supervised' and 'claim' sentenses --------- Co-authored-by: Ondrej Kosarko <[email protected]> * UFAL/Share submission with user not only admin (#728) * The submitter information cannot be displayed in some cases, but show a few information about the Item * Added missing trailing comma * Fixed docs * Updated messages following last commit to upstream. (#731) * Updated dspace prefix to lindat (#734) * Added notification when the shibboleth authentication is failed (#732) * Removed two IT: (#737) 1. Author does not have a two input fields. 2. Test for checking the notice step will be transformed into UI test, because we do not want to keep such specific collection for generic IT. * Update all static licenses (#726) * added licenses from ufal commit dcbe87e02931dee78b13c4b3995a6cef3aeacd32 * added missing static licenses * remove static from licenses path * no_static_ as const * checkstyle * Use NAMESPACES from the .env (#727) * Use NAMESPACES from the .env * Created symbolic link for the tomcat folder * Updated docker compose files - can load more properties from the `.env` * Update deploy.yml to increase timeout (#738) Because some tests were canceled during processing. * Use only 4000, not the {UI_PORT} from the .env because in the container it is always 4000 (#740) * Update docker-compose-rest.yml Uncommented /repository/ namespace in the docker-compose.yml. It is only for one deploy. * Update docker-compose-rest.yml Undo exposing server on the /repository/ path * Use only / and /server namespaces, not the values from the .env because in the container it is always `/` and `/server` (#741) * Expose tomcat `/server` on `/repository/server` * Take a customized docker-compose-rest.yml which exposes the server on /repository/server * Updated a path to take right docker-compose files * Undo using only default namespaced `/` and `/server` * Use custom `docker-compose.yml` from the testing server * UFAL/Shibboleth fixed wrong redirect after login with verification token (#733) * Used hardredirect instead of the standard router.redirect because the user could be stucked on the loading page * Added doc why * Added missing whitespace * Use path `./assets` instead of `/assets` (#742) * new download instruction for cmd using zip from backend (#739) * Get UI base URL from BE (#744) * Check that the custom type bind field in configured in the `submission-forms` when it is configured in the cfg property (#745) * Searching by type is changed to 'type' instead of 'itemtype' because it was changed in the autocomplete enhnancement (#749) * Use `autoLogin` method (#747) * UFAL/Matomo statistics using angulartics2 (#748) * Modified matomo tracking in footer component * Do not use routerless Matomo because we want to track view on every page redirect * The Matomo statistics are tracked properly. * Prettyfied the code * Fix linting error * Fixed unit tests following the matomo statistics update * Fixed linting error * Added a document title in the footer * Added category to the eventTrack because it is required for the Matomo. * Refactored using matomo statistics - added into browser init service, because the Matomo statistics wasn't rendered on production * Changed matomo-settings location --------- Co-authored-by: Matus Kasak <[email protected]> * Update db-import action Try a commit when the import worked. * Update import-db action - use main branch * Added a translation for the searching filter `subjectFirstValue` (redirect from home page). (#752) * Ensure the redirect URL starts with a slash (#753) * Added volume into docker-compose (#754) * UFAL/Load the matomo configuration from the environment (#755) * Added volume into docker-compose * Take a matomo configuration from the environment * Fetch the matomo properties from the config, not from the environment (#756) * Load the szn license in oninit method (#757) * UFAL/Temporary fix for the type-bind. The form automatically refreshes after the type is changed. (#761) * The Save action is automatically dispatched when the type is changed * Updated the handleFormSave method name to `dispatchFormSaveAndReinitialize` * Added missing function to mock object * Execute autoregistration component only in client side (#762) * The Autocomplete Component is dynamically loaded as a standalone component only in the browser using the Loader component. (#763) * UFAL/footer header images (#760) * Footer images upload to assets/images/footer/ and change of images src attributes * Changed src paths to start with ./ --------- Co-authored-by: Juraj Roka <[email protected]> * ufal/customize the footer (#759) * Footer details update by Lindat live instance's footer * Copied UI tests fix from the dtq-dev --------- Co-authored-by: Juraj Roka <[email protected]> Co-authored-by: milanmajchrak <[email protected]> * Copied fixes from the lindat branch (#770) * Copied PR 769 * Used root URL to compose download URL with namespace (#768) * Cherry-picked docker compose rest * The dtq-dev is run on /repository branch * Waiting for the http://dev-5.pc:8$INSTANCE/server/api changed to http://dev-5.pc:8$INSTANCE/repository/server/api * Added `repository` namespace to discojuice * Run UI integration tests every hour * Update actions/upload-artifact@v3 to v4 Because it was deprecated and UI tests cannot be run * Run build CRON every 4 hours * Update deploy.yml - changed runner * Update deploy.yml - updated runner everywhere * Update deploy.yml - use `dspace-dep-1` runner again * Fixed failing Integration tests (#773) * Commented out sometimes failing accessibility tests and added wait method to the submission ui test * Cherry picked fix for unique artifact name. --------- Co-authored-by: Tim Donohue <[email protected]> * Update import action.yml - use `/repository` namespace in the import action * Merge pull request DSpace#2694 from hutattedonmyarm/dspace-7_x (#777) [Port dspace-7_x] Enable type-bind for checkbox inputs during submission Co-authored-by: Tim Donohue <[email protected]> * Update build.yml - added a option to manually run build action * save logs * missing $ * print log file name for check * removed superfluous space * renamed log file -> added 'log' at the end of the name * Ufal/License issues (#779) * Fixed pagination when searching licenses by the name. * Fixed Editing license: 1. wrong checked checkboxes for the required info and extended license labels and removed errors from the console. * Update action.yml - defined log_file * Update action.yml - log import into a specific path * Update action.yml - continuously copy logs from the import into another file * Update action.yml - import logging - show path info * Update action.yml - log import - copy logs after they are created * Update action.yml - Start appending when the first file is added to the __logs folder * Added a new workflow which runs a build workflow in every customer * Fixed copying of the import logs to the dev machine (#786) * The copying of the import logs are not creating a new `tail` job every 2s * Call the import every week (#787) * UFAL/Use namespace in the redirect URL (#794) * Use current activated route as a parameter to the `createUrlTree` to compose correct redirect url (#796) * UFAL/Fixed CMD download command - added name (#798) * UFAL/Fixed editing the license - required info is removed/added following the checked checkbox Co-authored-by: Juraj Roka <[email protected]> * UFAL/Copy the refbox content correctly (#801) * Copy the refbox content correctly * Added missing parts of the modal * UFAL/The current version redirect - get the base href using the DOCUMENT (#800) * Get the base href using the DOCUMENT * UFAL/Start the handle server before tomca * Sync with ufal main (#799) * Merge pull request #7 from uib-ub/fix-warnings Address warnings in dockerfiles and composer files * Show resource id (not handle id) in manage handles (ufal#22) * show the resourceId in handle-table * show the resourceId and handle id in edit-handle --------- Co-authored-by: Marvin <[email protected]> * use i18n --------- Co-authored-by: Marvin <[email protected]> * UFAL/Edit item - fixed license redirect Co-authored-by: Juraj Roka <[email protected]> * Add custom dimension (handle) to pageTrack of matomo (#823) * Add custom dimension (handle) to pageTrack of matomo This extends/overrides the pageTrack/eventTrack methods of angulartics matomo plugin and hooks into the event tracking (view-tracker.component) that's there for DSpace internal statistics. * Fix linting issues and PR review comments * Fix tests - misconfigured test env * UFAL/Change menu options redirects (#816) * Change menu options redirects * Fix some menu options redirects by Coderabbit's nitpick comments * Adding cs/en by current language and translating slugs in About-menu * Unit tests - Edit of component.spec file * Typos in comments * UFAL/Preview - fixed loading files (#825) * Show loading icon when loading the files with a asking to contant the administrator when it took so long * The (listOfFiles | async) could be null add a `?` check after it. * UFAL/Handle table issues - Fixed table responsivity and searching (#822) * Fixed table responsivity and searching * Move `table-responsive` to div because it ensures more consistent responsiveness across browsers * Use `combineLatest` because it is more common for RxJS, refactor if condition * UFAL/Redirect to `/lindat` after clicking on the Lindat icon in the home page (#828) * Redirect to `/lindat` after clicking on the Lindat icon in the home page * Update deploy.yml - use correct deploy action for the weekly import * UFAL/Menu options links edit (#832) * Changed the getLangCodeIfCzech links * Changed the dropdown-menu and services links * Ufal dtq sync (#836) * Creating docker-compose file useful for building clarin-dspace on MAC computers (cherry picked from commit 7de4761) * Add link to communities and collections on home page (cherry picked from commit 4673e39) --------- Co-authored-by: Milan Kuchtiak <[email protected]> * UFAL/Updated the no file preview message and refactored some code (#837) * Updated the no file preview message and refactored some code. * Added a non null check when accessing the object properties and the message is refactored. * Run Python import weekly * UFAL/Added spacing between clarin & dspace logo (#848) * Added spacing between clarin & dspace logo * Spacing is prettier and when clarin logo is removed, dspace logo is centered * Ufal/seznam license request (#844) * Fix of unwanted Seznam Dataset License request while using other licenses * ZCU-PUB/Fixed encoding of the filename from the URL (#838) (#851) * Added an URL serializer to fix encoding of the special characters from the URL e.g., `[`, `(` because the filename wasn't properly parsed * Added some unit tests for encoding the bitstream filename url * UFAL/Do not mount the Solr configs; copy them each time instead. (#850) * UFAL/Fix the bulk access (#852) * Do not use the clarin item view box for the bulk access * Removed unused import * Clarify the `showClarinViewBox` is boolean * Use the constant for the hardcoded bulk access list id * Ufal dtq sync 2025 05 14 (#855) * Create Acknowledgment-ReadMe.md Acnkowledgment of NRP project (cherry picked from commit ad889b2) * Video files previews This uses the thumbnail as poster (if available) and correctly sets the source of the video currently only works for anonymously accessible files. (cherry picked from commit 4832c2f) * Handle video previews for restricted items append a shortlived token at the right time (error, seeking, stalled) (cherry picked from commit 2c12d7d) * Display only ORIGINAL bitstreams Thumbnails, when available, should be shown istead of the generic MIME_TYPE_IMAGE. Content of the TEXT bundle should not be shown at all this is usually automatically extracted "text layer" of a PDF, useful for indexing, but don't want people downloading it. (cherry picked from commit 3862442) * fix linter and test errors (cherry picked from commit f852096) * Code review follow up the listOfFiles should really not contain files from "TEXT" or "THUMBNAIL" bundles. * code review unsubscribe error$, seeking$ and $stalled * code review - thumbnail might be undefined * code review - consistent formatting * UFAL/Do not add `dtoken` into the URL if it is null (#860) (#861) * UFAL/Added same spacing styles via bootstrap as in login page (#862) * UFAL/Fixed editing of extended license labels * UFAL/License agreement page component errors (#867) * Design fix - added spaces between links * Fix of firstMedataValue null properties * UFAL/Ask Only Once license not downloading bitstream without page reload after agreeing (#874) * Changed logic (condition) of retrieving file download link * Saved the original logic, but changed caching parameter * The filename wasn't properly encoded when it has ?sequence...&isAllowed in the URL, because that query part of the URL was encoded as the filename. (#873) * UI tests for each customer (#865) * Playright after deploy running here * Using different token * Corrected path in copying json file * Checkout only branch in UI tests not master * Added copilot changes --------- Co-authored-by: Matus Kasak <[email protected]> * Ufal dtq sync062025 (#877) * use `$DSPACE_REST_NAMESPACE` for the webapps symlink (cherry picked from commit 9ea936e) * Licenses sync (cherry picked from commit 4ee2f1c) * update header/footer based on latest lindat-common 3.5.0 (cherry picked from commit 7b2f299) * expose both tcp & udp ports of the handle server (cherry picked from commit 46bc936) * Update docker-compose-rest.yml replace ../webapps with /usr/local/tomcat/webapps --------- Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Ondrej Kosarko <[email protected]> * UFAL/License Administration Labels & Required Info checkboxes should work properly (#881) * hotfix - finding index of unchecked box properly to formName arg * UFAL/Searching problems in Manage Handles table (#882) * locked searchbar when searchOption is not picked * edited Resource Type search option to not be case-sensitive * edited Resource Type search option to show nothing when there is no match * try to set lowercase constants without toLowerCase method * Added full list of handles for empty Resource Type search option * refactored empty searchQueries handling and added comment for invalid resourcetype search inputs * Updating UI tests after import (#887) Co-authored-by: Matus Kasak <[email protected]> * UFAL/Show openaire input field every time the EU funding type is selected (#897) * Show openaire input field every time the EU type is selected * UFAL/Publisher search redirect not work #880 (#904) Co-authored-by: milanmajchrak <[email protected]> * Ufal/commits from ok lindat (#903) * copied static content that was not already in cs/. Otherwise license page (when without .html) might show an error when UI is in Czech and there's no translation. (cherry picked from commit 9e7eea0) * Update header.component.html I'm expecting the image to take me to lindat.cz. There's no other obvious way to navigate out of the repository * This is the change from ufal/clarin-dspace@5fc2414 but applied on v7 * Adding a note about the proprietor change --------- Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Michal Kren <[email protected]> * UFAL/show-no-spinner-when-item-has-no-files (#902) * show msg about no files when item has no files, show no spinenr * check if files are array * check files size * fix error * optimize template with hasNoFiles flag * used behaviourSubject for hasNoFiles / aynchronous * Trigger automated ui tests (#905) * Created trigger for running UI tests for each customer daily * Corrected spaces * Changed name of the tests --------- Co-authored-by: Matus Kasak <[email protected]> * UFAL/License agreement loading spinner after submitting (#892) * Added loading spinner icon after 'I agree' button is clicked * Removed type annotation and rephrased comment * Changes isLoading to async object * Edited loading spinner visibility method - consistency fix * UFAL/User cannot see his submission (#910) * The user always see it's submissions page --------- Co-authored-by: Paurikova2 <[email protected]> * Changed runner in playwright tests (#914) Co-authored-by: Matus Kasak <[email protected]> * Skipping some customer branches in trigger playwright tests (#918) Co-authored-by: Matus Kasak <[email protected]> * UFAL/Return to pool issue (#922) * UFAL/Shibboleth redirect to item without permission - not login page but 403 (#920) * Updated retrieving the dso object - redirect to 403 instead of login page. Check if the user is signed in. * Updated commend and fixed eslint warning * UFAL/The editor cannot download the workflows bitstream (#924) * Added `authorization-token` to the request, so the user could be identified in the BE context * Added notification error when downloading has failed * UFAL/Cherry-pick - update the static licenses were missing an update in the czech translation. Co-authored-by: Ondrej Kosarko <[email protected]> * UFAL/Upgrade the refbox component - the content is fetched from the BE (#930) * Fetch the refbox content from the BE * Show an error that the refbox content wasn't properly fetched when some error * Sanitize the code from the BE. Show errors and proper messages when something has failed * Load item name in on init * Secure the refbox content using SafeHtml * Make refbox variable name consistent * Refactor fetching refbox string from the SafeHtml --------- Co-authored-by: Paurikova2 <[email protected]> Co-authored-by: Jozef Misutka <[email protected]> Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Matus Kasak <[email protected]> Co-authored-by: jurinecko <[email protected]> Co-authored-by: Juraj Roka <[email protected]> Co-authored-by: Tim Donohue <[email protected]> Co-authored-by: Paurikova2 <[email protected]> Co-authored-by: Ondřej Košarko <[email protected]> Co-authored-by: Marvin <[email protected]> Co-authored-by: Milan Kuchtiak <[email protected]> Co-authored-by: Kasinhou <[email protected]> Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Michal Kren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Summary by CodeRabbit