-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decouple re-frame and reagent+core.async #107
Closed
Closed
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
0e182a2
decouple re-frame and reagent+core.async
darwin a54eaf1
forgot to remove extra apply
darwin 200aef2
remove debug logging
darwin 6bf1aba
fix broken project repo url
darwin 6e9eefd
bump project version to 0.5.0
darwin b7f78b8
minor refinements in tests
darwin 0f4fcd6
bump todomvc deps
darwin 5ee36de
add checkouts so that todomvc uses local sources
darwin 329a57f
fix comp-middleware
darwin b62e3ab
integrate cljs-devtools into todomvc
darwin 072ac10
integrate cljs-devtools into simpleexample
darwin bae4df8
move legacy-subscribe to scaffold
darwin bd4602f
get-frame-transducer does the work directly
darwin dc0981a
provide no-loggers for convenience
darwin c05223f
default loggers should apply all args
darwin 2778d5a
switch frame implementation to use defrecord
darwin 3d72b79
enable figwheel nrepl in examples
darwin addfb80
rename frame-factory to make-frame
darwin c09f3c6
minor refinements in core tests
darwin 7a8156d
properly override protocol on defrecord
darwin 568cdd3
move "handler returned nil" check into transducer
darwin 751ccfb
add test "calling a handler which does not exist"
darwin a56a6e7
give our transducer some love
darwin 173e824
move frame-summary-description to utils
darwin a52d360
add possibility to unregister subscription/event handlers
darwin 4137a0d
in case of processing only one event we can use transducer directly
darwin 12e9b66
better logging helpers
darwin 049285b
return pure handler for compatibility reasons
darwin e9f525d
fix a typo
darwin 9b31889
DRY logger helpers
darwin 5f4be3c
use defonce to make scaffold figwheel reloadable
darwin 4a7873d
various tweaks to increase reusability of scaffold code
darwin f393cc4
move transduce-event(s)-by-resetting-atom to utils
darwin 5ff3204
transducer factory: transducers are parametrized by db-selector
darwin 14314dd
add tests to exercise event processing
darwin e534e6a
frame polishing
darwin ff346a8
add frame/process-events
darwin 8f61e93
move log recording helpers under test.utils.log-recording ns
darwin 911ab0f
add tests to exercise triggering subscriptions
darwin df66bf5
when triggering subscription make sure sub-id matches
darwin 22e91e1
DRY definition of recording-loggers
darwin dc82af6
refactor resetting atoms
darwin 6ad431f
mark side-effecting functions as such
darwin 069b7cc
missing newline before EOF in utils.cljs
darwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add frame/process-events
- Loading branch information
commit ff346a866be689be091f674f775cadb396ab1054
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern:
is appearing in quite a few places, it might be better refactor it out to a separate fn: