Skip to content
This repository has been archived by the owner on Nov 3, 2024. It is now read-only.

Update Puppeteer Chrome recipe to support latest ddev web image version and workaround for Apple M1 arch #196

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

juban
Copy link
Contributor

@juban juban commented Jan 29, 2022

The New Solution:

This PR provides a reliable way to make Puppeteer run inside the ddev web container (replacing the current "Puppeteer Headless Chrome support" recipe).

How this PR Solves The Problem:

The previous recipe was not working anymore on latest ddev web container images (> 1.16) because of outdated packages.
Also, the current chromium bundled version in Puppeteer is not working on Apple Silicon M1 architecture.
This update provides a workaround by overriding the webimage_extra_packages configuration to install a native chromium package which puppeteer will use instead of the bundled one.

Manual Testing Instructions:

Follow instructions provided in the recipe recipes/puppeteer-chromium-support/README.md file.

Related Issue Link(s):

#192 (Not directly related as the "Headless Chrome for Behat Testing" service seams to work fine on M1)

@rfay
Copy link
Member

rfay commented Jan 29, 2022

Please reach out for some other puppeteer users to review this, thanks!

@juban
Copy link
Contributor Author

juban commented Jan 30, 2022

@rfay Will do. Do you have anyone in mind I could reach out in the ddev community? @isholgueras or @jonaseberle maybe?

@jonaseberle
Copy link
Collaborator

Installing headless browsers into the web container is not for me. I also don't use Puppeteer but selenium hub with chrome and firefox.

@juban juban changed the title Update Puppeteer Chrome recipe to support ddev 1.6 and upper and workaround for Apple M1 arch Update Puppeteer Chrome recipe to support ddev 1.16 and upper and workaround for Apple M1 arch Jan 30, 2022
@rfay
Copy link
Member

rfay commented Jan 31, 2022

Current ddev stable is v1.18, not sure why this is trying to support v1.16 and higher?

@juban
Copy link
Contributor Author

juban commented Feb 1, 2022

@rfay In fact, the previous recipe stopped working starting ddev 1.16, in other words, the updated recipe will work on ddev 1.16 and upper. Sorry for not being clear.

@rfay
Copy link
Member

rfay commented Feb 2, 2022

Thanks for the explanation. I'm not sure the difference is worth explaining, or that it's worth encouraging people to use ddev v1.16 :)

@juban
Copy link
Contributor Author

juban commented Feb 2, 2022

Yes, maybe a simple "latest ddev version" would be better, I agree. I wanted to stick to the contribution guidelines which state that the goal of the update should be specified clearly.
I'll simplified that.

@juban juban changed the title Update Puppeteer Chrome recipe to support ddev 1.16 and upper and workaround for Apple M1 arch Update Puppeteer Chrome recipe to support latest ddev web image version and workaround for Apple M1 arch Feb 2, 2022
@juban
Copy link
Contributor Author

juban commented Feb 3, 2022

I fixed the README file accordingly.

@rfay
Copy link
Member

rfay commented Mar 16, 2022

Could you please rebase this and test with ddev v1.19.0?

Thanks!

@rfay
Copy link
Member

rfay commented Dec 31, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants