Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): patch experiments #533

Closed
wants to merge 11 commits into from
+41 −0
Closed

chore(api): patch experiments #533

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ebc258b
test
Nov 21, 2024
d7ea269
fix patch
Nov 21, 2024
4f1a637
test
Nov 21, 2024
72e631b
trying
Nov 21, 2024
f0b30e0
1
Nov 21, 2024
6681869
trying useSerial
Nov 25, 2024
ab7e1cc
try to fix
Nov 25, 2024
de4302b
test comment
Nov 25, 2024
e8cac42
p
Nov 25, 2024
3456c5d
ppp
Nov 25, 2024
7b83303
patch
Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
test 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Valeriy Khorunzhin committed Nov 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 4f1a6370782bbce3cefd1beac673799c18a417ca
13 changes: 0 additions & 13 deletions images/virt-artifact/patches/024-test.patch
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
diff --git a/pkg/instancetype/instancetype.go b/pkg/instancetype/instancetype.go
index 6860766acd..c11f92a6dd 100644
--- a/pkg/instancetype/instancetype.go
+++ b/pkg/instancetype/instancetype.go
@@ -1598,7 +1598,7 @@ func applyFirmwarePreferences(preferenceSpec *instancetypev1beta1.VirtualMachine
}

if firmware.PreferredUseBiosSerial != nil && vmiFirmware.Bootloader.BIOS != nil && vmiFirmware.Bootloader.BIOS.UseSerial == nil {
- vmiFirmware.Bootloader.BIOS.UseSerial = pointer.P(*firmware.PreferredUseBiosSerial)
+ vmiFirmware.Bootloader.BIOS.UseSerial = pointer.P(true)
}

if vmiFirmware.Bootloader.EFI == nil && vmiFirmware.Bootloader.BIOS == nil && firmware.PreferredEfi != nil {
diff --git a/pkg/virt-launcher/virtwrap/util/libvirt_helper.go b/pkg/virt-launcher/virtwrap/util/libvirt_helper.go
index 35b9f98808..52b76e27f0 100644
--- a/pkg/virt-launcher/virtwrap/util/libvirt_helper.go