Skip to content

docs: drop removed Deno 1 APIs from the architecture page and FFI note - #3512

Open
ragib-mrb wants to merge 1 commit into
denoland:mainfrom
ragib-mrb:docs-remove-deno1-apis
Open

ragib-mrb wants to merge 1 commit into
denoland:mainfrom
ragib-mrb:docs-remove-deno1-apis

Conversation

@ragib-mrb

Copy link
Copy Markdown

Two spots still describe Deno 1 behavior:

  • Architecture Overview (runtime/contributing/architecture.md) demonstrates Deno.resources(), Deno.close() and Deno.metrics(). The Deno 1.x to 2.x migration guide lists all three as removed (Deno.metrics() has no replacement). This drops the Metrics section and its table row, and rewrites the Resources section: rids are internal now, resources are closed with .close() on their owner (e.g. Deno.FsFile), and the deno test resource sanitizer is the way to catch leaks.
  • FFI (api/deno/index.md) says to run with --allow-ffi and --unstable, but the command below it only uses --allow-ffi, and FFI isn't in the unstable flags reference anymore. The text now says --allow-ffi only.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant