Skip to content

Fix number input accepting characters in Firefox#396

Merged
prateek3255 merged 3 commits intomainfrom
fix-firefox-number-input
Apr 29, 2023
Merged

Fix number input accepting characters in Firefox#396
prateek3255 merged 3 commits intomainfrom
fix-firefox-number-input

Conversation

@prateek3255
Copy link
Contributor

@prateek3255 prateek3255 commented Apr 29, 2023 •
edited
Loading

What does this PR do?

  • Adds a condition in onKeyDown to prevent character inputs in Firefox when input type is number, because Firefox allows non-number inputs for input type number
  • Adds a warning to avoid people from overriding important inputProps provided by renderInput

Fixes #393

@prateek3255 prateek3255 merged commit facf432 into main Apr 29, 2023
@prateek3255 prateek3255 deleted the fix-firefox-number-input branch April 29, 2023 06:42
@prateek3255 prateek3255 mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Input field accepts multiple characters in single field for inputType number.

1 participant

@prateek3255