Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add commonLabels, commonAnnotations, podLabels and podAnnotations #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ecthelion77
Copy link

Overview

What this PR does / why we need it

Special notes for your reviewer

Checklist

  • Change log updated in Chart.yaml (see the contributing guide for details)
  • Chart version bumped in Chart.yaml (see the contributing guide for details)
  • Documentation regenerated by running make docs

@ecthelion77
Copy link
Author

/assign @sagikazarmark

@sagikazarmark
Copy link
Member

Thanks for submitting a PR!

To be honest, I'm not sure I understand why all this change is necessary to implement this feature.

  • Why the added dependency?
  • Why the formatting changes in values.yaml?
  • Documentation format is not followed in values.yaml

I'd probably just modify the dex.labels template and create another one called dex.annotations.

Even then, I'm not sure why this feature is necessary: most objects already support adding custom labels and annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants