Handle no indicators provided in sms_attachments.py (mvt-project#455)

* Handle no indicators provided in `sms_attachments.py` * Move guard to a more specific place * Unrelated black formatting * Related black changes :)
dfirfpi · Feb 7, 2024 · 4681b57 · 4681b57
1 parent bb7a22e
commit 4681b57
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/mvt/ios/modules/mixed/calls.py b/mvt/ios/modules/mixed/calls.py
@@ -69,9 +69,9 @@ def run(self) -> None:
                     "isodate": convert_mactime_to_iso(row[0]),
                     "duration": row[1],
                     "location": row[2],
-                    "number": row[3].decode("utf-8")
-                    if row[3] and row[3] is bytes
-                    else row[3],
+                    "number": (
+                        row[3].decode("utf-8") if row[3] and row[3] is bytes else row[3]
+                    ),
                     "provider": row[4],
                 }
             )

diff --git a/mvt/ios/modules/mixed/sms_attachments.py b/mvt/ios/modules/mixed/sms_attachments.py
@@ -56,7 +56,9 @@ def serialize(self, record: dict) -> Union[dict, list]:
     def check_indicators(self) -> None:
         for attachment in self.results:
             # Check for known malicious filenames.
-            if self.indicators.check_file_path(attachment["filename"]):
+            if self.indicators and self.indicators.check_file_path(
+                attachment["filename"]
+            ):
                 self.detected.append(attachment)
 
             if (