Fix onSelect shows isHalfSelected = true for Branch Nodes #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ke1sy
reviewed
Aug 24, 2023
…when propagateSelect=false and after children deselected not possible to select parent.
Collaborator
Author
|
Changes in this commit where done because of this issue: The code that caused it was added during #109. |
Ke1sy
reviewed
Aug 24, 2023
mellis481
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch nodes do not broadcast the expected state when their onSelect events fire. When deselected, the only onSelect that fires shows isHalfSelected as true when it should be false.
Ref: UIEN-4766