Add FromDhall instances for {Int,Word}{,8,16,32,64}
#2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
german1608
approved these changes
Aug 29, 2020
Collaborator
german1608
left a comment
There was a problem hiding this comment.
Really cool! That TypeApplication extension fitted perfectly here.
sjakobi
reviewed
Aug 29, 2020
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
Does the fact that the added decoders can fail after type-checking actually matter in practice?! If so, it should possibly be highlighted in the haddocks.
… as caught by @sjakobi Co-authored-by: Simon Jakobi <[email protected]>
Collaborator
Author
|
@sjakobi: Yeah, this is a departure from my previous policy of only providing |
sjakobi
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2007