Don't panic on Text/replace ""
#2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I verified that this passes |
sjakobi
approved these changes
May 11, 2021
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
Looks great! Ideally this should be merged together with the added tests from dhall-lang/dhall-lang#1172, but it doesn't matter much.
dhall/src/Dhall/Eval.hs
Outdated
Comment on lines
608
to
612
| let hLamInfo = case needle of | ||
| VTextLit (VChunks [] "") -> TextReplaceEmpty | ||
| _ -> Prim | ||
|
|
||
| in VHLam hLamInfo $ \replacement -> |
Collaborator
There was a problem hiding this comment.
So that's how you include the lambda in the TextReplaceEmpty case! :) I hadn't figured that out.
Collaborator
Author
|
I can wait until the upstream tests are merged |
… caught by one of the newly-added regression tests
… for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2181