Preserve string interpolation when using dhall-format
#220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #216 This changes the internal representation of `TextLit` to be able to store an interpolated string literal. Preserving string interpolation in the syntax tree means that `dhall-format` can also preserve interpolation. This also simplifies a lot of the string-interpolation-related code, which is now simpler and more strongly typed.
Member
|
Looks good! Maybe worth throwing in my example in #216 as a regression test? |
Member
|
Oh btw, there is still a comment at the top of |
Collaborator
Author
|
Oh, good catch! I'll fix that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216
This changes the internal representation of
TextLitto be able tostore an interpolated string literal. Preserving string interpolation in
the syntax tree means that
dhall-formatcan also preserveinterpolation.
This also simplifies a lot of the string-interpolation-related code,
which is now simpler and more strongly typed.