Improve robustness of :let command
#2297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2296 The root cause of the above bug was that the old parser for `:let` commands was too lenient. In particular, given a command like: ``` :let x : T = e ``` … the old parser would silently ignore the `: T` part of the command. This change fixes that by adding support for type annotations and fixing the `:let` command to exactly match the standard parser in terms of what expressions it permits.
sjakobi
approved these changes
Sep 1, 2021
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
LGTM modulo a small readability issue.
… as suggested by @sjakobi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2296
The root cause of the above bug was that the old parser for
:letcommands was too lenient. In particular, given a command like:
… the old parser would silently ignore the
: Tpart of the command.This change fixes that by adding support for type annotations and
fixing the
:letcommand to exactly match the standard parser interms of what expressions it permits.