Improve performance heap utilization of parser #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decreases the heap utilization of the parser by over 10x (~5.5 MB to 350 KB) and improves performance by about 18% on the example benchmark program from #108 Before: time 289.9 ms (274.6 ms .. 297.9 ms) 0.999 R² (0.998 R² .. 1.000 R²) mean 309.3 ms (301.0 ms .. 318.3 ms) std dev 11.08 ms (8.083 ms .. 14.31 ms) After: time 245.6 ms (243.0 ms .. 247.1 ms) 1.000 R² (1.000 R² .. 1.000 R²) mean 247.5 ms (246.5 ms .. 248.6 ms) std dev 1.338 ms (1.022 ms .. 1.636 ms)
I checked in this change by mistake, but it has no effect
This reverts commit 6faa03c. Turns out that it actually did make a performance difference after all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decreases the heap utilization of the parser by over 10x (~5.5 MB to
350 KB) and improves performance by about 18% on the example benchmark
program from #108
Before:
After: