Skip to content

Conversation

@sellout
Copy link
Collaborator

@sellout sellout commented Apr 12, 2019

Fixes #890.

@sellout
Copy link
Collaborator Author

sellout commented Apr 12, 2019

The dhall-lang submodule will need to be updated once dhall-lang/dhall-lang#486 is merged.

@Gabriella439
Copy link
Collaborator

dhall-lang/dhall-lang#486 is merged so if you update this branch then tests should now pass

@sellout
Copy link
Collaborator Author

sellout commented Apr 14, 2019

Looks like the largeExpression parser test now fails.

/cc @singpolyma, since they made the latest change to that test.

@f-f
Copy link
Member

f-f commented Apr 16, 2019

@sellout yeah it looks like there's something with that test: now both dhall-haskell master and dhall-clj master produce the same parse for it, and the result differs from the one in dhall-lang.
However dhall-lang/dhall-lang#488 will change it again, so we could wait for that (though it will require changes in dhall-haskell)

@singpolyma
Copy link
Contributor

I've merged dhall-lang/dhall-lang#488 now -- not sure how the failure happened before since I produce that .dhallb file previously with dhall encode -- now the version in master is produced with dhall-ruby and should be correct for the changes in 488

@sellout
Copy link
Collaborator Author

sellout commented Apr 25, 2019

Should this wait on #903, then?

@Gabriella439
Copy link
Collaborator

@sellout: Yeah, if you update to the latest master then you should pick up all relevant changes

@Gabriella439 Gabriella439 merged commit 1073d04 into dhall-lang:master May 3, 2019
@Gabriella439
Copy link
Collaborator

Thanks for fixing this! 🙂

@sellout sellout deleted the with-sorts branch May 6, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can’t merge two record sorts.

4 participants