Allow changing of throttle delays via options#41
Closed
deckchairhq wants to merge 2 commits intodinbror:masterfrom
Deckchair:master
Closed
Allow changing of throttle delays via options#41deckchairhq wants to merge 2 commits intodinbror:masterfrom Deckchair:master
deckchairhq wants to merge 2 commits intodinbror:masterfrom
Deckchair:master
Conversation
|
@thinkgareth Looks good any chance you could fix the merge conflicts? |
Owner
|
Added to version 1.5.1. Sorry for the late implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thankyou for this great little library!
My use case involves displaying hundreds of images on a single page. Some people scroll quickly to the bottom or middle of the page and I don't want all the images to load in the interim, i'll be setting my throttle somewhere between 250ms and 750ms.
The default values haven't changed and the pull request is completely innocuous to the library, it can be merged without any concerns.
The less hard-coded unchangeable values.. the better, even if they are slightly obscure 😃