Breakpoint switch detection: revalidates images when switch occurs#50
Breakpoint switch detection: revalidates images when switch occurs#50andr3 wants to merge 3 commits intodinbror:masterfrom
Conversation
|
@dinbror friendly ping? :) |
|
Although your Edit: After bit of a thinking, I have these two scenarios, when your function may cause headache:
Hopefully, you understand, what I mean :) This is mostly Windows/Linux issue, since on Mac the scrollbars are hidden by default afaik. |
In this PR the following major changes are introduced:
The data-* attributes are no longer removed. Was there any strong reason to remove them? I have an idea to still be able achieve the major goal even if the attributes are removed.
On each
validate()it checks if the resize jumped across a breakpoint. If no breakpoints are defined, the additional code doesn't even run.Let me hear your feedback and I can fine-tune this, fix and
push -fso that the merge is as clean as possible.Cheers @dinbror!