[SpotTarget]Edge sampler with excluding edges adjacent to low-degree nodes #5893

jwzhi · 2023-06-20T19:36:59Z

Description

This issue is for extending the function of excluding the training edges in the edge sampler used in the link prediction training.
We develop a new callable excluder object which can be used as an args in dgl.dataloading.as_edge_prediction_sampler.
The example usage is as follows

low_degree_excluder = SpotTarget(g, args.exclude_target_degree)
sampler = as_edge_prediction_sampler(sampler, exclude=low_degree_excluder, reverse_eids=reverse_eids,
                                                      negative_sampler=negative_sampler.Uniform(1))

A more detailed documents and experiment results can be found here #5698.

Checklist

Please feel free to remove inapplicable items for your PR.

The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
I've leverage the tools to beautify the python and c++ code.
The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
All changes have test coverage
Code is well-documented
To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
Related issue is referred in this PR
If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot · 2023-06-20T19:37:28Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-06-20T19:37:40Z

Commit ID: ec5d93e

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-06-20T19:42:20Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-06-20T19:42:32Z

Commit ID: 122a65c

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

BarclayII · 2023-06-25T06:29:20Z

@dgl-bot

dgl-bot · 2023-06-25T06:31:12Z

Commit ID: 122a65c

Build ID: 3

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

python/dgl/dataloading/base.py

BarclayII · 2023-06-25T06:40:16Z

Also, would you mind add a new unit test? We typically add unit tests of data loading in tests/python/pytorch/dataloading so you could add a test_... function in a new file like tests/python/pytorch/dataloading/test_spot_target.py.

There are also some lint errors in the file. You could fix it with lintrunner -a python/dgl/dataloading/base.py.

jwzhi · 2023-06-30T17:36:34Z

lintrunner -a python/dgl/dataloading/base.py

I will add these features.

Do you have example test functions that I can take a look at. Sorry I haven't written any unit test before and need an example for this.

dgl-bot · 2023-07-11T01:56:59Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-07-11T01:57:11Z

Commit ID: 7e624e6

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

BarclayII · 2023-07-11T01:57:54Z

lintrunner -a python/dgl/dataloading/base.py

I will add these features.

Do you have example test functions that I can take a look at. Sorry I haven't written any unit test before and need an example for this.

Sorry for not responding @jwzhi . An example unit test is https://github.com/dmlc/dgl/blob/master/tests/python/pytorch/dataloading/test_dataloader.py#L727.

dgl-bot · 2023-07-22T02:23:26Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-07-22T02:23:37Z

Commit ID: 59c881f

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-07-22T02:27:40Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-07-22T02:27:52Z

Commit ID: a1d67e7

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

jwzhi · 2023-07-22T02:56:57Z

@dgl-bot

dgl-bot · 2023-07-22T03:14:44Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-07-22T03:14:57Z

Commit ID: 5977b24

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-07-24T05:23:51Z

@dgl-bot

dgl-bot · 2023-08-04T02:58:05Z

Commit ID: 24ebe87

Build ID: 22

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

Rhett-Ying · 2023-08-04T03:00:22Z

@dgl-bot

dgl-bot · 2023-08-04T03:02:29Z

Commit ID: 24ebe87

Build ID: 23

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot · 2023-08-04T03:16:15Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-04T03:16:27Z

Commit ID: d911e9d

Build ID: 24

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-08-04T03:23:35Z

@dgl-bot

dgl-bot · 2023-08-04T03:25:43Z

Commit ID: 31836b8796def0c9718422808576436c6f183761

Build ID: 25

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot · 2023-08-04T03:27:53Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-04T03:28:05Z

Commit ID: 3264dcae7c9373b020c3f805811db43c4b915a5d

Build ID: 26

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-08-04T03:41:38Z

@dgl-bot

dgl-bot · 2023-08-04T03:41:51Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-04T03:42:04Z

Commit ID: e465b49

Build ID: 27

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-08-04T03:43:36Z

Commit ID: e465b49

Build ID: 28

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot · 2023-08-04T04:00:21Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-04T04:00:33Z

Commit ID: 18929b9

Build ID: 29

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-08-04T04:33:11Z

@dgl-bot

dgl-bot · 2023-08-04T04:35:09Z

Commit ID: 18929b9

Build ID: 30

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot · 2023-08-04T06:44:53Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-04T06:45:05Z

Commit ID: d1896a0183557bd25afdf5cf22f521a867b4b7fd

Build ID: 31

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-08-04T06:56:44Z

@dgl-bot

dgl-bot · 2023-08-04T07:53:44Z

Commit ID: d61b8f95c07a8bc7adf3a07a6d16b5e0b79c76c8

Build ID: 32

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

BarclayII

Thanks for your contribution!

…nodes (#5893) Co-authored-by: Quan (Andy) Gan <[email protected]> Co-authored-by: ZYH <[email protected]> Co-authored-by: Hongzhi (Steve), Chen <[email protected]>

…nodes (dmlc#5893) Co-authored-by: Quan (Andy) Gan <[email protected]> Co-authored-by: ZYH <[email protected]> Co-authored-by: Hongzhi (Steve), Chen <[email protected]>

add spottarget as an exclude args

ec5d93e

add spottarget dependency

122a65c

jwzhi changed the title ~~Edge sampler with excluding edges adjacent to low-degree nodes~~ [SpotTarget]Edge sampler with excluding edges adjacent to low-degree nodes Jun 20, 2023

jwzhi mentioned this pull request Jun 20, 2023

[RFC] Edge sampler with excluding edges adjacent to low-degree nodes #5698

Closed

BarclayII reviewed Jun 25, 2023

View reviewed changes

python/dgl/dataloading/base.py Outdated Show resolved Hide resolved

frozenbugs self-requested a review June 26, 2023 05:36

Merge branch 'master' into master

7e624e6

Merge branch 'dmlc:master' into master

59c881f

update

a1d67e7

change format

5977b24

Merge branch 'master' into master

9b3f50e

add the module docstring

d911e9d

add the module docstring

e1b3435

Merge branch 'master' into master

e465b49

remove the trailing white space

18929b9

remove the trailing white space

477690e

BarclayII approved these changes Aug 4, 2023

View reviewed changes

BarclayII merged commit a1a3ce8 into dmlc:master Aug 4, 2023

[SpotTarget]Edge sampler with excluding edges adjacent to low-degree nodes #5893

[SpotTarget]Edge sampler with excluding edges adjacent to low-degree nodes #5893

Uh oh!

Conversation

jwzhi commented Jun 20, 2023

Description

Checklist

Changes

Uh oh!

dgl-bot commented Jun 20, 2023

Uh oh!

dgl-bot commented Jun 20, 2023

Uh oh!

dgl-bot commented Jun 20, 2023

Uh oh!

dgl-bot commented Jun 20, 2023

Uh oh!

BarclayII commented Jun 25, 2023

Uh oh!

dgl-bot commented Jun 25, 2023

Uh oh!

Uh oh!

BarclayII commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwzhi commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgl-bot commented Jul 11, 2023

Uh oh!

dgl-bot commented Jul 11, 2023

Uh oh!

BarclayII commented Jul 11, 2023

Uh oh!

dgl-bot commented Jul 22, 2023

Uh oh!

dgl-bot commented Jul 22, 2023

Uh oh!

dgl-bot commented Jul 22, 2023

Uh oh!

dgl-bot commented Jul 22, 2023

Uh oh!

jwzhi commented Jul 22, 2023

Uh oh!

dgl-bot commented Jul 22, 2023

Uh oh!

dgl-bot commented Jul 22, 2023

Uh oh!

frozenbugs commented Jul 24, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

Rhett-Ying commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

frozenbugs commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

frozenbugs commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

dgl-bot commented Aug 4, 2023

Uh oh!

BarclayII commented Jun 25, 2023 •

edited

Loading

jwzhi commented Jun 30, 2023 •

edited

Loading