Skip to content

Removed hard-coded database information and replaced them with database calls#1004

Merged
dondi merged 1 commit intobetafrom
Onariaginosa
Dec 5, 2022
Merged

Removed hard-coded database information and replaced them with database calls#1004
dondi merged 1 commit intobetafrom
Onariaginosa

Conversation

@Onariaginosa
Copy link
Collaborator

Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the hardcode removal is notable and is worth a version bump—will do that after merging

Similar style notes here as in #996 and in similar places also, so I didn’t leave redundant notes here anymore. Going through the #996 comments as stated in #1002 should still suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants