Skip to content

#1055 Make the node coloring menu for top bar and side bar to be cons…#1128

Merged
dondi merged 1 commit intobetafrom
maika-1055
Oct 23, 2024
Merged

#1055 Make the node coloring menu for top bar and side bar to be cons…#1128
dondi merged 1 commit intobetafrom
maika-1055

Conversation

@ntran18
Copy link
Collaborator

@ntran18 ntran18 commented Oct 23, 2024

…istent, and fix lint errors

Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—funny about those formatting-only changes: wonder why Prettier hadn’t done those yet

}
if (grnState.mode === NETWORK_PPI_MODE) {
displayPPINodeColorWarning();
displayPPINodeColorWarning();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow—interesting that Prettier hasn’t fixed these on its own 🤔

if (grnState.nodeColoring.showMenu) {
showNodeColoringMenus();
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too!

@dondi dondi merged commit b327f0f into beta Oct 23, 2024
@dondi dondi deleted the maika-1055 branch October 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants