1080: Node Coloring Navbar and Sidebar synced and PPI warning displays less#1129
Merged
1080: Node Coloring Navbar and Sidebar synced and PPI warning displays less#1129
Conversation
…arning when user first displays node coloring with PPI
Collaborator
Author
|
Need to make changes in other files to prevent errors with errors displaying in console before merging. |
…efreshes whenever restrictGraphToViewport is clicked already. This removes error with path containing NaNs from displaying in the console.
…out attribute not having .length. will probably have to go back to #1080 and reserve issue there
…e usr eot update logic for when check node adaptive or though
…correctly for node coloring. investigating why when load a database, it says it's NETWORK_PPI_MODE and even though node coloring enabled, node coloring doesn't display on node until change dataset and len of timepoints array is 0, so not querying expression database correctly
… warning displays when load a database too
…MODE, and removed that code so that now databases load in correct mode
…r and side menu display the same status of node coloring and when node coloring disabled, the navbar and sidebar options for node coloring are hidden
dondi
approved these changes
Oct 30, 2024
Owner
dondi
left a comment
There was a problem hiding this comment.
Question on default dataset was answered during meeting; all good
web-client/public/js/graph.js
Outdated
| .attr("stroke-width", "0px") | ||
| .style("fill", function (d) { | ||
| d = d || 0; // missing values are changed to 0 | ||
| if (d == 0) { |
Owner
There was a problem hiding this comment.
Triple equals plz 😁
Suggested change
| if (d == 0) { | |
| if (d === 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navbar and Sidebar synced when enable/disable node coloring, and warning only displays when enable/disable node coloring. Also, the navbar and sidebar options for node coloring are hidden when node coloring disabled.