Conversation
… namespaces and addition of timestamp. need to test that queries work correctly
ntran18
commented
Feb 19, 2025
server/dals/network-dal.js
Outdated
| gene_regulatory_network.gene WHERE (gene.gene_id ='${gene}' | ||
| OR gene.display_gene_id ='${gene}')`; | ||
| ${namespace} WHERE (gene.gene_id ='${gene}' | ||
| OR gene.display_gene_id ='${gene}') AND gene.time_stamp ='${timestamp}'`; |
Collaborator
Author
There was a problem hiding this comment.
Old namespace doesn't have timestamp so this would cause error
| (LOWER(gene.gene_id)=LOWER('${geneProtein}') OR LOWER(gene.display_gene_id)=LOWER('${geneProtein}') | ||
| OR LOWER(protein.standard_name) =LOWER('${geneProtein}')) AND | ||
| LOWER(gene.gene_id) = LOWER(protein.gene_systematic_name);`; | ||
| ${namespace}.gene, ${namespace}.protein WHERE |
Collaborator
Author
There was a problem hiding this comment.
Similar here, old namepsace doesn't have timestamp. Additionally, if we query from protein table, then we should check the timestamp from the protein table. If we query from gene table, then we should check the timestamp from the gene table.
…ry to only have timestamp query if timestamp is 2025 or later. need to fix query though since ZAP1 gene is not showing correct self-regulating expression
…constants.js, removed trailing spaces.
…ed constants to dbConstants, and now queries don't perform correctly
…ot currently using dbConstants file
…s and protein-dals. correctly make query based on timestamp, need to check if add source to query
Collaborator
Author
|
I verified the code is working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.