Conversation
dondi
left a comment
There was a problem hiding this comment.
pretty good almost there:
- Let’s delete the .pyc files. Side issue will be to review .gitignore to see why these were allowed through
- Merge the latest
betainto this branch so that older changes don’t get mixed in
|
Thank you @ntran18 for helping with deleting files and merging beta! I reversed what I had added so that the code aligns with what was discussed during the meeting. There will always be two opt-groups either Demo or User-Uploaded and Expression Database, even if there is no data in User-Uploaded. That seems to be it, everything is in order otherwise! |
dondi
left a comment
There was a problem hiding this comment.
Thanks for cleaning out the files! I spotted something I missed earlier, but nbd
| NETWORK_GRN_MODE | ||
| } from "./constants"; | ||
| import { getWorkbookFromForm, getWorkbookFromUrl } from "./api/grnsight-api"; | ||
| import { updateLocale } from "moment"; |
There was a problem hiding this comment.
I think I missed this from before—this looks like an unused import? Either way I won’t let it block the PR; it has no effect as of now and can be fixed easily later
There was a problem hiding this comment.
Not sure where that came from but I took it out!
I tested our solution and it seems to work. I just have a question about what opt-groups should be visible when the user loads from the database? Currently my solution only shows the Expression Database data as the opt-group when the user loads from the database and enables node coloring.